Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TIFU by sending non-compiling code to main. Self-slab.
Against my better judgement, PR #38 sent non-working code to main. In the code that was merged,
set_fan_modewas never actually defined, and the version that was tested on an actual NUSense was not the version that was sent to main, and because there is no build test on this repo, it slipped through and got merged...This PR fixes this by actually defining
set_fan_modeand also removes a redundant definition of a function that was brought in by STM32CubeMX.This code has been compiled using STM32CubeIDE, however my existing PR #39 adds a build test to stop this from happening again by the way of PlatformIO integration :D.